Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web engineering to the CODEOWNERS file for website tooling, but not content. #29418

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add web engineering to the CODEOWNERS file for website tooling, but not content. #29418

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ff52fe
Add web eng permissions for website tooling, but not content
judithpatudith Jan 25, 2025
392ce76
remove vault eng from website directory
judithpatudith Jan 31, 2025
db9016d
remove vault eng from block comments
judithpatudith Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,19 @@
/vault/plugin_catalog.go @hashicorp/vault-ecosystem

# Content on developer.hashicorp.com
/website/ @hashicorp/vault-education-approvers

# Engineering and web presence get notified of, and can approve changes to web tooling, but not content.

/website/ @hashicorp/web-presence @hashicorp/vault
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding @hashicorp/vault as an owner for files under /website/ and the content-specific folders below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning was that we would want the engineering team to have complete control over their own repo, in case (and I know this is very unlikely) there was a problem in one of these files that blocked a release or some other emergency. I don't think we explicitly exclude these directories from CI and release tooling, so I just want to make sure there's nothing in here that engineering couldn't fix on their own in a pinch.

/website/data/
/website/public/
/website/content/

# Education and engineering get notified of, and can approve changes to web content.

/website/data/ @hashicorp/vault-education-approvers @hashicorp/vault
/website/public/ @hashicorp/vault-education-approvers @hashicorp/vault
/website/content/ @hashicorp/vault-education-approvers @hashicorp/vault
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/website/data/ @hashicorp/vault-education-approvers @hashicorp/vault
/website/public/ @hashicorp/vault-education-approvers @hashicorp/vault
/website/content/ @hashicorp/vault-education-approvers @hashicorp/vault
/website/data/ @hashicorp/vault-education-approvers @hashicorp/vault
/website/public/ @hashicorp/vault-education-approvers @hashicorp/vault
/website/content/ @hashicorp/vault-education-approvers @hashicorp/vault
/website/templates/ @hashicorp/vault-education-approvers @hashicorp/vault

I'm leaving the @hashicorp/vault references for now, but I don't think it's appropriate. If specific teams what notifications for docs related to their work, I understand that, but making all of Vault owners for the docs will create a lot of extra GitHub noise and also allow folks to bypass EDU review for doc changes.


# Plugin docs
/website/content/docs/plugins/ @hashicorp/vault-ecosystem @hashicorp/vault-education-approvers
Expand Down
Loading