update tlsConfig & namespaceSelector for metrics serviceMonitor #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamps5
commented
May 14, 2024
•
iamps5
commented
- Update the comment to fix the default selector label in serviceMonitor
- Added namespaceSelector field - this is required incase ServiceMonitor is deployed in any other namespace instead of VSO namespace
- Added tlsConfig[] to add CA certificates, client certificates and client keys for SSL/TLS certificates validation on metrics' serviceMonitor. Without these we don't even have option to add these configuration in serviceMonitor
|
@benashz can you please let me know if you are going to accept these changes? If yes, when? thanks |
|
Latest commit - has a quick fix for updating the image tag for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.