Skip to content

Conversation

@github-actions
Copy link
Contributor

Backport

This PR is auto-generated from #38010 to be assessed for backporting due to the inclusion of the label 1.14-backport.

The below text is copied from the body of the original PR.


Summary

  • replace_triggered_by now reports an error when given an invalid attribute reference that does not exist in the target resource

Test plan

  • Added unit test TestContext2Plan_triggeredByInvalidAttribute
  • Existing replace_triggered_by tests pass
  • Manual testing with null_resource confirms invalid references now produce errors
  • Valid attribute references continue to work correctly

Fixes #36740


Overview of commits

@github-actions
Copy link
Contributor Author

Changelog Warning

Currently this PR would target a v1.15 release. Please add a changelog entry for in the .changes/v1.15 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label.

@SarahFrench
Copy link
Member

Changelog Warning

Currently this PR would target a v1.15 release. Please add a changelog entry for in the .changes/v1.15 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label.

This automation needs fixing 😭 - I've moved the change file into the correct folder for the base branch

@SarahFrench SarahFrench marked this pull request as ready for review December 17, 2025 20:08
@SarahFrench SarahFrench requested a review from a team as a code owner December 17, 2025 20:08
@jbardin
Copy link
Member

jbardin commented Dec 18, 2025

I think the automation worked correctly here. This was targeted for 1.15, so shouldn't have a backport. If this were intended for 1.14 the changelog should only be for that one version.

We do however have a problem in the rare case that a patch needs to be in two minor versions at once. There we currently have to manually backport each version to avoid the conflicting changlog entries from failing the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants