Add deprecation surpression tracking #38000
Open
+128
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
added
the
no-changelog-needed
DanielMSchmidt
force-pushed
the
add-deprecation-surpression-tracking
branch
from
5402a27 to
008e320
Compare
jbardin
reviewed
Dec 11, 2025
internal/deprecation/deprecation.go
Outdated
|
|
||
| func (d *Deprecations) IsModuleCallDeprecationSuppressed(addr addrs.Module) bool { | ||
| for _, mod := range d.suppressedModules { | ||
| if addr.Equal(mod) || mod.TargetContains(addr) { |
Member
There was a problem hiding this comment.
Shouldn't TargetContains already be true if Equal is true?
Contributor
Author
There was a problem hiding this comment.
Good point, this is double it seems :D
| Forget bool | ||
| Actions *actions.Actions | ||
| // only allowed in the context of a destroy plan. | ||
| Forget bool |
Member
There was a problem hiding this comment.
I think the comment only applies to Forget? Probably add a line break in here to make it clear. I see Actions was grouped in here already, but I don't think that applies
Contributor
Author
There was a problem hiding this comment.
Oh yeah the comment is only for forget, I'll add a line break!
DanielMSchmidt
force-pushed
the
add-deprecation-surpression-tracking
branch
from
008e320 to
8b295d5
Compare
This struct tracks and validates deprecations in the context of a graph walk. We need a struct to keep track of the module calls that opt-out of deprecation warnings.
DanielMSchmidt
force-pushed
the
add-deprecation-surpression-tracking
branch
from
8b295d5 to
2746850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to track and supress deprecations on a module basis. For the full end-to-end implementation see #37795, this PR splits up that work into more reviewable chunks. This PR is based on #37999
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry