PSS: Add stateStoreInitFromConfig method to Meta
#37723
Merged
+456
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
SarahFrench
commented
Oct 3, 2025
Comment on lines
+1673
to
+1857
| // NOTE: the backend version of this method, `backendInitFromConfig`, prompts users for input if any required fields | ||
| // are missing from the backend config. In `stateStoreInitFromConfig` we don't do this, and instead users will see an error. | ||
| func (m *Meta) stateStoreInitFromConfig(c *configs.StateStore, factory providers.Factory) (backend.Backend, cty.Value, cty.Value, tfdiags.Diagnostics) { |
There was a problem hiding this comment.
Highlighting this comment.
The backend equivalent of this method prompts users for input when required fields aren't set. I find this to be an odd feature; is this a first-class feature that gives users a preferable was to pass values into Terraform? If there are missing fields I'd expect an error to happen and users to update their config and/or ENVs.
I'm assuming it's a legacy-ish feature that we wouldn't choose to add now, so I've excluded it from this implementation. If feature request for this comes in future we can act on it.
SarahFrench
force-pushed
the
pss/add-state-stor-init-from-config-method
branch
from
525fe3b to
eaf8717
Compare
SarahFrench
changed the title
stateStoreInitFromConfig method to MetastateStoreInitFromConfig method to Meta, update savedStateStore to include chunk size negotiation.
SarahFrench
force-pushed
the
pss/add-state-stor-init-from-config-method
branch
from
7bc1477 to
f5de2b3
Compare
SarahFrench
changed the base branch from
main
to
pss/add-chunk-negotiation-impl
SarahFrench
changed the title
stateStoreInitFromConfig method to Meta, update savedStateStore to include chunk size negotiation.stateStoreInitFromConfig method to Meta
…st to assert it's set
…sed in, add unhappy path tests
SarahFrench
force-pushed
the
pss/add-chunk-negotiation-impl
branch
from
28af9dd to
9237ded
Compare
…ides with state stores
… of accepting all BackendOpts This is to avoid confusion, e.g. unnecessary duplication of config being passed in.
…hunk size is negotiated
…rror if the provider doesn't return a chunk size > 0
SarahFrench
force-pushed
the
pss/add-state-stor-init-from-config-method
branch
from
f5de2b3 to
9304b20
Compare
SarahFrench
commented
Oct 6, 2025
radeksimko
approved these changes
Oct 6, 2025
|
|
||
| func configBodyForTest(t *testing.T, config string) hcl.Body { | ||
| t.Helper() | ||
| f, diags := hclsyntax.ParseConfig([]byte(config), "", hcl.Pos{Line: 1, Column: 1}) |
There was a problem hiding this comment.
Suggested change
| f, diags := hclsyntax.ParseConfig([]byte(config), "", hcl.Pos{Line: 1, Column: 1}) | |
| f, diags := hclsyntax.ParseConfig([]byte(config), "", hcl.InitialPos) |
https://pkg.go.dev/github.com/hashicorp/hcl/[email protected]#pkg-variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
stateStoreInitFromConfigmethod that's similar to the existingbackendInitFromConfigmethod onMeta.The
stateStoreInitFromConfigmethod added in this PR is used to get abackend.Backendinstance that uses pluggable state storage internally. The returned PSS is configured using the configuration in the TF project, in contrast to thesavedStateStoremethod that does the same but uses backend state files for configuring the state store. These methods are both analogous tobackendInitFromConfigandsavedBackend.Additionally, this PR adds some test coverage for a related method,
stateStoreConfig.Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry