search: Drop identity from state if no identity schema is present #37709
+77
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
added
no-changelog-needed
jbardin
approved these changes
Oct 1, 2025
Closed
3 tasks
dbanck
added a commit
that referenced
this pull request
Oct 6, 2025
…7709) * Modernize Go * Check if identity schema is present before decoding state * Test identity decoding from state without schema
3 tasks
dbanck
added a commit
that referenced
this pull request
Oct 6, 2025
…7709) * Modernize Go * Check if identity schema is present before decoding state * Test identity decoding from state without schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the state decoding logic. When we have identity data in state, but the provider doesn't have an identity schema (likely in the case of a downgrade), we won't try to decode the identity data. Instead we skip decoding and will silently drop the identity data from state. The identity data will be added back to state if a user upgrades to a provider version that supports resource identity again.
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry