Skip to content

Conversation

ab-cs13
Copy link
Contributor

@ab-cs13 ab-cs13 commented Oct 21, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No

Description

Adding capability to enable terraform practitioner to delete underlying oci resource while deleting odb network. If set to true, it will delete associated oci resource. Default set to false.

References

odb network :
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/odb_network

Output from Acceptance Testing

Test evidence attached in the PR.

… delete associated OCI resources or not. default set to false.
@ab-cs13 ab-cs13 requested a review from a team as a code owner October 21, 2025 15:45
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

⚠️ Our automation has detected the following potential issues with your pull request


❌ Maintainer Edit Permissions (Click to expand)

At times, our maintainers need to make direct edits to pull requests in order to prepare it to be merged. At the time of opening this pull request, your settings do not allow maintainers to make such edits. If possible, update your settings as described in the following document. If your fork is owned by an organization that limits your ability to make this change, please let us know.

Please see the GitHub documentation on allowing changes to a pull request branch created from a fork for additional details.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/odb Issues and PRs that pertain to the odb service. size/L Managed by automation to categorize the size of a PR. labels Oct 21, 2025
@ab-cs13
Copy link
Contributor Author

ab-cs13 commented Oct 22, 2025

Test evidences

Screenshot 2025-10-22 at 10 02 21 Screenshot 2025-10-18 at 19 13 42 Screenshot 2025-10-16 at 21 45 35 Screenshot 2025-10-16 at 14 28 32

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Oct 22, 2025
@ab-cs13
Copy link
Contributor Author

ab-cs13 commented Oct 22, 2025

Screenshot 2025-10-22 at 13 41 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/odb Issues and PRs that pertain to the odb service. size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant