feature: Add ListOrganizations & GetOrganizationDetails tfe tools #64
Conversation
| allOrgs = append(allOrgs, orgList.Items...) | ||
| totalCount = orgList.TotalCount | ||
|
|
||
| if len(allOrgs) >= totalCount || len(orgList.Items) == 0 { |
There was a problem hiding this comment.
Why is it necessary to check len(allOrgs) >= totalCount? Wouldn't this always trigger on the first iteration since we are comparing the totalCount of the list with the same length list of orgList.Items?
There was a problem hiding this comment.
len(allOrgs) >= totalCount is used to determine when we've collected all organizations across paginated responses. Since orgList.Items only contains the current page's results, we need to track the total across all pages. This check ensures we stop once we've fetched everything based on the totalCount value returned by the API.
The len(orgList.Items) == 0 check is an additional safeguard in case the API doesn't return the full count or if something unexpected happens (like a partial page).
There was a problem hiding this comment.
ah okay so allOrgs just represents what's on the page while totalCount is the total organization count across all pages.
Can we include a comment on this or maybe rename to be clearer?
There was a problem hiding this comment.
Updated variable names to make it clearer.
aditya2548
changed the title
| pageNumber := 1 | ||
| totalCount := 0 | ||
|
|
||
| // Iterate through all pages to collect all organizations |
There was a problem hiding this comment.
this should be done in a separate PR but we should look into how we can have single pagination implementation for use across all tools since I imagine we'll be running into pagination constantly.
Edit: created a issue here
gautambaghel
merged commit 9643aa3
into
feature/tfenterprise-long-lived
Changes
HCP_TFE_TOKENandHCP_TFE_ADDRESSenvironment variables.