Upgrade armon/go-metrics to hashicorp/go-metrics #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixup the library to remove the dual v1 & v2 paths. Now the main branch will support only v3. v3 is API compatible and on-disk-storage compatible with v2. The main difference is that it requires the application to be using hashicorp/go-metrics instead of armon/go-metrics in order for metrics to be emitted properly.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixup the library to remove the dual v1 & v2 paths. Now the main branch will support only v3.
v3 is API compatible and on-disk-storage compatible with v2. The main difference is that it requires the application to be using hashicorp/go-metrics instead of armon/go-metrics in order for metrics to be emitted properly.
For users still on v1 they should upgrade to v2, do the migration and then do a subsequent upgrade to v3.
Once this is merged a new v3.0.0 tag of the library will be made.