add ci linting and fix existing lint errors #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeetviswa
commented
Apr 14, 2025
Comment on lines
-169
to
+171
| switch { | ||
| switch lExpr { | ||
| // intentionally not checking raw, since can be an empty string | ||
| case lExpr == nil: | ||
| case nil: |
There was a problem hiding this comment.
Fixes:
expr.go:169:2: QF1002: could use tagged switch on lExpr (staticcheck)
switch {
^
Comment on lines
-126
to
+143
| switch { | ||
| case r == eof: | ||
| switch r { | ||
| case eof: | ||
| break WriteToBuf | ||
| case r == backslash: | ||
| case backslash: | ||
| nextR := l.read() | ||
| switch { | ||
| case nextR == eof: | ||
| switch nextR { | ||
| case eof: | ||
| tokenBuf.WriteRune(r) | ||
| return nil, fmt.Errorf("%s: %w in %q", op, ErrInvalidTrailingBackslash, tokenBuf.String()) | ||
| case nextR == backslash: | ||
| case backslash: | ||
| tokenBuf.WriteRune(nextR) | ||
| case nextR == delimiter: | ||
| case delimiter: | ||
| tokenBuf.WriteRune(nextR) | ||
| default: | ||
| tokenBuf.WriteRune(r) | ||
| tokenBuf.WriteRune(nextR) | ||
| } | ||
| case r == delimiter: // end of the quoted string we're scanning | ||
| case delimiter: // end of the quoted string we're scanning |
There was a problem hiding this comment.
Fixes:
lex.go:126:3: QF1002: could use tagged switch on r (staticcheck)
switch {
^
lex.go:131:4: QF1002: could use tagged switch on nextR (staticcheck)
switch {
^
| @@ -159,7 +159,6 @@ WriteToBuf: | |||
| // lexSymbolState scans for strings and can emit the following tokens: | |||
| // orToken, andToken, containsToken | |||
| func lexSymbolState(l *lexer) (lexStateFunc, error) { | |||
| const op = "mql.lexSymbolState" | |||
There was a problem hiding this comment.
Fixes:
lex.go:162:8: const op is unused (unused)
const op = "mql.lexSymbolState"
^
Let me know if leaving this in adds any value. Other functions declare an op to be used in lexing error strings.
Comment on lines
-187
to
+190
| switch { | ||
| case p.currentToken.Type == symbolToken: | ||
| switch p.currentToken.Type { | ||
| case symbolToken: | ||
| return nil, fmt.Errorf("%s: %w %s == %s (expected: %s or %s) in %q", op, ErrInvalidComparisonValueType, p.currentToken.Type, p.currentToken.Value, stringToken, numberToken, p.raw) | ||
| case p.currentToken.Type == stringToken, p.currentToken.Type == numberToken: | ||
| case stringToken, numberToken: |
There was a problem hiding this comment.
Fixes:
parser.go:187:4: QF1002: could use tagged switch on p.currentToken.Type (staticcheck)
switch {
^
| var m reflect.Value = model | ||
| m := model |
There was a problem hiding this comment.
Fixes:
validate.go:35:8: ST1023: should omit type reflect.Value from declaration; it will be inferred from the right-hand side (staticcheck)
var m reflect.Value = model
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.