Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bettermap instead of go map #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

xuetusc
Copy link

@xuetusc xuetusc commented Sep 28, 2022

add bettermap instead of go map
delete go map key will only label it, not really delete that causes memory leak.

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 28, 2022

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


renbiao seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@jefferai
Copy link
Member

This code isn't thread safe. What's the memory leak exactly?

Is the benefit you see merely from swapping out the map instead of removing items?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants