Added workflow for test #176
Merged
+68
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonamtenzin2
force-pushed
the
sonamt/build-test
branch
from
f7e1c02 to
e4a73ff
Compare
sonamtenzin2
changed the title
|
will likely make this PR - #172 obsolete |
sonamtenzin2
commented
Apr 17, 2025
| @@ -73,6 +73,22 @@ func TestStatsd_Conn(t *testing.T) { | |||
| t.Fatalf("bad line %s", line) | |||
| } | |||
|
|
|||
| line, err = reader.ReadString('\n') | |||
There was a problem hiding this comment.
Some new lines were added in write to the test, thats why the original assertions have moved a few lines later
There was a problem hiding this comment.
Nothing has changed in the testcases, only the expectations. Were the tests always failing?
There was a problem hiding this comment.
Yeah, the test were already failing in the master
abhijeetviswa
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds workflow for running existing tests