-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add API docs for HCP RBAC #2588
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ New Page AddedThe following page was added to the bundle from the code in this PR:
One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After confirming with the team, this looks perfect to us!
Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello π , I have open questions in Slack about how the data is displayed and which apis are revealed. Please hold on merging π while we sort this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking with Trevor:, could we:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
Hiya @chris-hut and @xargs-P ! Thanks for catching the issue with the path-based grouping. That should be sorted now! I've also implemented some temporary shim code to delete the operation at For the "hidden endpoints", I think at some point very soon we'll want to find a more sustainable way to achieve this. For example, we could omit the operation entirely from the source spec file in hashicorp/hcp-specs. Or if that's not an option, and it needs to be included in that repo but hidden on our docs site, we could explore OpenAPI extensions, eg as discussed in this thread. (cc @emilypersson1 for this last bit, in case this merits a feature ticket or whatnot! π ) |
I added an asana task for hiding private endpoints as a future idea. ideally we can remove the endpoint from the spec for now, but if the RBAC team needs this functionality, we can take a look at prioritizing this work! |
This PR is stale because it has been open 20 days with no activity. It will be closed in 5 days unless you remove the |
53aaa28
to
4f6bddf
Compare
I've updated this PR to use our new OpenAPI docs template. It should be an equivalent user experience to the previous template, the big change is each operation is now on a separate page (we were having issues with some specs creating super large single pages otherwise). As mentioned earlier, we have a temporary shim code to delete the operation at schema.paths['/resource-manager/2019-12-10/projects'].post before rendering the document. I've retained this shim when moving to the new template. |
π Relevant links
ποΈ What
Stubs in a page for HCP RBAC API docs using the existing OpenAPI docs template.
πΈ Design Screenshots
π§ͺ Testing
π Anything else?
Not at the moment!