AppSideNav: add additional tests for when the nav is removed from the DOM
#3256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
didoo
reviewed
Sep 30, 2025
|
|
||
| <MockApp> | ||
| <:sidebar as |S|> | ||
| <S.SideNav |
There was a problem hiding this comment.
[question] instead of changing the existing MockAppSidebarAppSideNav, would make sense to have the logic to remove/add it from the DOM here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would add tests and a showcase example of the AppSideNav being removed from the DOM when in mobile view to verify that the overflow property is restored to the page.
SHOWCASE PREVIEW
🛠️ Detailed description
This work is the result of a ticket to audit the design system for components that reach outside of the component to the DOM. The only component besides Modal and Flyout that does this is AppSideNav.
The AppSideNav (unlike the SideNav) prevents scrolling on the page when it is expanded on a mobile screen by setting
overflow: hiddenon the body of the page.To verify that the component is properly cleaned up if it is removed from the DOM (which is unlikely), I added 2 things:
overflow: hiddenstyle is removed🔗 External links
Jira ticket: HDS-5025
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.