Skip to content

fix(components): add missing template registries #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aklkv
Copy link
Collaborator

@aklkv aklkv commented Jun 17, 2025

📌 Summary

  • use @nullvoxpopuli/ember-composable-helpers/template-registry template registry & remove local override if you think this needs to be something else open upstream PR
  • create local defenition of already depreciated helper capitalize from ember-cli-string-helpers in the gts future it would be easier reference @eber/string or better yet change-case function https://www.npmjs.com/package/change-case

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@aklkv aklkv self-assigned this Jun 17, 2025
@aklkv aklkv requested a review from a team as a code owner June 17, 2025 09:51
Copy link

vercel bot commented Jun 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 20, 2025 10:02am
hds-website ✅ Ready (Inspect) Visit Preview Jun 20, 2025 10:02am

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion and we'd need a changelog entry for the ember-composable-helpers bump – otherwise it's good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants