Skip to content

fix(showcase): adjust glint patch #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: fix/add-missing-template-registries
Choose a base branch
from

Conversation

aklkv
Copy link
Collaborator

@aklkv aklkv commented Jun 7, 2025

📌 Summary

It turns out I messed up my own patch during pnpm migration which broken type checking in showcase so this fixes it as well as correct configuration for ember-composable-helpers which didn't work correctly before. I add manual types for capitalize helper from now deprecated ember-cli-string-helpers, we should move to @ember/string but it's a bigger lift and easier to do when we move to single file components.

Another potential solution is to rename route components so we avoid collision with the classic pattern e.g. (this would require renaming all route references)

Screenshot 2025-06-09 at 4 58 34 PM

🛠️ Detailed description

📸 Screenshots

🔗 External links

Slack 🧵 : https://hashicorp.slack.com/archives/C05P1FMLP6U/p1748947829147119


💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@aklkv aklkv self-assigned this Jun 7, 2025
@aklkv aklkv requested a review from a team as a code owner June 7, 2025 22:00
Copy link

vercel bot commented Jun 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 17, 2025 11:03am
hds-website ✅ Ready (Inspect) Visit Preview Jun 17, 2025 11:03am

@RobbieTheWagner
Copy link
Member

I would highly recommend we rename the route and move the templates so we do not need to do the patch to workaround this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants