-
Notifications
You must be signed in to change notification settings - Fork 49
fix(showcase): adjust glint patch #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aklkv
wants to merge
9
commits into
fix/add-missing-template-registries
Choose a base branch
from
fix/glint-resolution
base: fix/add-missing-template-registries
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
910738a
to
ffa1a1f
Compare
dcec980
to
3e5818a
Compare
I would highly recommend we rename the route and move the templates so we do not need to do the patch to workaround this. |
3e5818a
to
79aa33b
Compare
22c730c
to
b6dce3e
Compare
a2c6a7e
to
936ec24
Compare
936ec24
to
fdc6b74
Compare
e6ebadb
to
1164860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
It turns out I messed up my own patch during pnpm migration which broken type checking in showcase so this fixes it as well as correct configuration for
ember-composable-helpers
which didn't work correctly before. I add manual types for capitalize helper from now deprecated ember-cli-string-helpers, we should move to@ember/string
but it's a bigger lift and easier to do when we move to single file components.Another potential solution is to rename route
components
so we avoid collision with the classic pattern e.g. (this would require renaming all route references)🛠️ Detailed description
📸 Screenshots
🔗 External links
Slack 🧵 : https://hashicorp.slack.com/archives/C05P1FMLP6U/p1748947829147119
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.