-
Notifications
You must be signed in to change notification settings - Fork 49
ember-intl
integration
#2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ember-intl
integration
#2878
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
15cad7c
to
d1d171c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me is a go! 👍
I've left only a few questions/thoughts (nothing major or blocker). If you decide to act on them let me know so I can re-approve.
Lovely PR, very well done! 🙌
packages/components/src/components/hds/pagination/info/index.hbs
Outdated
Show resolved
Hide resolved
packages/components/translations/hds/components/pagination/info/en-us.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Très bien! 🇫🇷 Only have a few non-blocking comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving
Given that it's pretty hard to follow is going on here and most importantly why we need this I would like to request to have RFC before this goes out |
Hey @aklkv . We need this as there is a broader organizational goal to internationalize our applications. Notably for french language requirements as we conduct business in Quebec. Are there some specific questions I can answer for you to help you figure out what's going on? |
{{/if}} | ||
</SG.Item> | ||
<SG.Item as |SGI|> | ||
<SGI.Label>Using the <code>hds-intl</code> service"</SGI.Label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</Hds::ApplicationState> | ||
</SG.Item> | ||
<SG.Item as |SGI|> | ||
<SGI.Label>Using the <code>ember-intl</code> <code>t</code> helper"</SGI.Label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<SGI.Label>Using the <code>ember-intl</code> <code>t</code> helper"</SGI.Label> | |
<SGI.Label>Using the <code>ember-intl</code> <code>t</code> helper</SGI.Label> |
[Nit] Trailing quotation mark. Note: this is on all the labels here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aklkv since this is an open-source project and we're working in the open, this repository is actually the best forum to raise any questions or concerns. that way, the full context is visible to @hashicorp/hds-engineering, and others who may have similar questions can benefit from the discussion. looking forward to continuing the conversation here. |
📌 Summary
If merged, this PR enables
ember-intl
for the components package and translates some of the bare strings. It also sets up linting rules preventing the usage of bare strings.Details
ember-intl
dependency to both theshowcase
andcomponents
workspaces.components
dir in a single en-us.yaml filecomponents
components
no-bare-strings
which prevents untranslated text nodesJira ticket: HDS-4856
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.