Password credential migration script #6125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgajjala8
changed the title
bgajjala8
force-pushed
the
bgajjala-update-db-changes
branch
from
058a8fd to
6c6d89c
Compare
bgajjala8
changed the title
louisruch
reviewed
Oct 7, 2025
internal/db/schema/migrations/oss/postgres/99/01_credential_static_password_credential.up.sql
Outdated
Show resolved
Hide resolved
bgajjala8
force-pushed
the
bgajjala-update-db-changes
branch
from
0cb88c6 to
13232bd
Compare
laero
reviewed
Oct 8, 2025
There was a problem hiding this comment.
while reviewing, i realized that i missed a table in my previous PR, which is also used in views that needs to be updated. let's add that table + view update in this PR, if that's okay with you?
new table
credential_vault_library_password_mapping_override
update views to select from that new table:
credential_vault_library_issue_credentialscredential_vault_library_list_lookup
internal/db/schema/migrations/oss/postgres/99/01_credential_static_password_credential.up.sql
Outdated
Show resolved
Hide resolved
|
re: new table and view updates: |
bgajjala8
force-pushed
the
bgajjala-update-db-changes
branch
from
387f455 to
d345a1c
Compare
bgajjala8
force-pushed
the
bgajjala-update-db-changes
branch
from
df6882c to
2c87201
Compare
bgajjala8
force-pushed
the
bgajjala-update-db-changes
branch
from
2c87201 to
9b6d364
Compare
laero
approved these changes
Oct 8, 2025
bgajjala8
merged commit f70918e
into
llb-password-credential-type
56 of 58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR updates the migration changes to include updated to current tables.
Associated Jira Ticket