Makefile: check for existence of dist in build-ui-ifne #6119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build-ui-ifne target is responsible for deciding whether the UI assets already exist on disk, or need to be built by cloning the UI repo and running its build scripts. The old configuration would check whether the UI repo folder existed, and assume that as long as this folder exists, it can be used to embed the UI assets. However, if the clone or ui build fails at any point, the Makefile target isn't able to retry the script. Correct the path that is checked for to be the path that is actually included in the assets.go file. This way, the Makefile script will retry building the UI until a dist folder is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build-ui-ifne target is responsible for deciding whether the UI assets already exist on disk, or need to be built by cloning the UI repo and running its build scripts.
The old configuration would check whether the UI
repo folder existed, and assume that as long as this folder exists, it can be used to embed the UI assets. However, if the clone or ui build fails at any point, the Makefile target isn't able to retry the script.
Correct the path that is checked for to be the path that is actually included in the assets.go file. This way, the Makefile script will retry building the UI until a dist folder is created.
PCI review checklist