Skip to content

Conversation

bgajjala8
Copy link
Contributor

Add CLI support for password credentials :

  • Generating password_credentials.gen.go CLI framework
  • Implementing password_funcs.go with password-specific flags
  • Registering create/update commands in CLI router

This enables password credentials through the CLI:

  • boundary credentials create password
  • boundary credentials update password

@bgajjala8 bgajjala8 changed the title feat(cli): Add password credential CLI commands Add password credential CLI commands Oct 6, 2025
@bgajjala8 bgajjala8 marked this pull request as ready for review October 6, 2025 18:28
@bgajjala8 bgajjala8 requested a review from a team as a code owner October 6, 2025 18:28
@bgajjala8 bgajjala8 marked this pull request as draft October 6, 2025 18:28
@bgajjala8 bgajjala8 requested review from laero and removed request for a team October 6, 2025 18:28
@bgajjala8 bgajjala8 self-assigned this Oct 6, 2025
@bgajjala8 bgajjala8 marked this pull request as ready for review October 6, 2025 18:29
@bgajjala8 bgajjala8 changed the title Add password credential CLI commands Add password credential CLI command Oct 6, 2025
@bgajjala8
Copy link
Contributor Author

bgajjala8 commented Oct 8, 2025

@laero We will hold from merging this PR until API and Repository changes are complete.

@bgajjala8 bgajjala8 marked this pull request as draft October 8, 2025 17:50
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a bats test to this, see https://github.com/hashicorp/boundary/blob/main/internal/tests/cli/boundary/credentials.bats
Note that as you mentioned until the API/domain changes are complete that test wont do much

@bgajjala8
Copy link
Contributor Author

bgajjala8 commented Oct 8, 2025

Would be good to add a bats test to this, see https://github.com/hashicorp/boundary/blob/main/internal/tests/cli/boundary/credentials.bats Note that as you mentioned until the API/domain changes are complete that test wont do much

@louisruch Yep! I can make these test additions as part of this PR

@bgajjala8
Copy link
Contributor Author

bgajjala8 commented Oct 10, 2025

@laero I added credential bats tests and added unimplemented message to the credential service. This will fail when running the bats test until the service implementation is completed. Should we go ahead with reviewing and getting this part in now that we have some testing in place?

cc: @louisruch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants