Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): Add note for modifying /etc/hosts #5499

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented Jan 30, 2025

This PR updates the enos readme to include a note for modifying /etc/hosts. This is needed when using docker-based scenarios to allow the use of container names in addresses.

@moduli moduli added the pr/no-milestone Ignores the Milestone Check label Jan 30, 2025
@moduli moduli requested a review from a team as a code owner January 30, 2025 15:09
Copy link
Contributor

@amitsk6 amitsk6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moduli moduli merged commit 26608ed into main Jan 31, 2025
66 of 67 checks passed
@moduli moduli deleted the moduli-e2e-docker-readme branch January 31, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-milestone Ignores the Milestone Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants