Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet configuration information #97

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zanctor
Copy link

@zanctor zanctor commented Apr 5, 2024

Description:
This PR adds information on configuring a wallet application properly to use the WalletConnect pairing modal.
The suggested approach should help solve the communication problem (#82) between a dApp and an extension wallet using standard WalletConnect capabilities.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@zanctor zanctor mentioned this pull request Apr 8, 2024
2 tasks
@franfernandez20
Copy link
Contributor

Thank you @zanctor for your contribution. I find the support for this scenario interesting, I believe it would be helpful to include information on how to manage the next requests after pairing. The wallet owner should manage this redirection to pop and remove the created tab.

Anyway, in my opinion, auto-closing tabs immediately after opening is not an elegant approach. I have attached a video showing the results:
https://github.com/hashgraph/hedera-wallet-connect/assets/23079185/c7227ba5-33f2-4f15-9147-60014ba856ce

Please let us know if you have a better experience in any way.

return;
}

const wcUri = uri.searchParams.get("uri");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, there should also be managed a request that is not for pairing but the next requests like wc?requestId=xxx

@Volind
Copy link

Volind commented Apr 9, 2024

Thank you @zanctor for your contribution. I find the support for this scenario interesting, I believe it would be helpful to include information on how to manage the next requests after pairing. The wallet owner should manage this redirection to pop and remove the created tab.

Anyway, in my opinion, auto-closing tabs immediately after opening is not an elegant approach. I have attached a video showing the results: https://github.com/hashgraph/hedera-wallet-connect/assets/23079185/c7227ba5-33f2-4f15-9147-60014ba856ce

Please let us know if you have a better experience in any way.

With auto-closing approach user will see the page for a fraction of a second and that's exactly what's happening with deeplinks on mobile. But for DApps when they don't need to add anything for new wallets support and just using WC logic that's already integrated is beneficial.

Next requests from DApps will be transferred through WC transport in the existing session. So no need to do anything else. This part is only needed for pairing (in a way like deeplinks do).

@franfernandez20
Copy link
Contributor

Thank you @zanctor for your contribution. I find the support for this scenario interesting, I believe it would be helpful to include information on how to manage the next requests after pairing. The wallet owner should manage this redirection to pop and remove the created tab.
Anyway, in my opinion, auto-closing tabs immediately after opening is not an elegant approach. I have attached a video showing the results: https://github.com/hashgraph/hedera-wallet-connect/assets/23079185/c7227ba5-33f2-4f15-9147-60014ba856ce
Please let us know if you have a better experience in any way.

With auto-closing approach user will see the page for a fraction of a second and that's exactly what's happening with deeplinks on mobile. But for DApps when they don't need to add anything for new wallets support and just using WC logic that's already integrated is beneficial.

Next requests from DApps will be transferred through WC transport in the existing session. So no need to do anything else. This part is only needed for pairing (in a way like deeplinks do).

Absolutely no, the deepLink on mobile is natively contemplated and you don't see any rare behaviour when opening.

I agree that is better to use WC capabilities but I think this won't fulfil the necessities of all dApps. My suggestion is to keep both possibilities, open the wallet through WC logic or the suggested approach in Feat/extension popup (#82) improved by eip-6963

@franfernandez20
Copy link
Contributor

Please take a look at the comment in #PR-82 regarding this particular goal

@hgraphql hgraphql requested review from a team, valeraOlexienko, teacoat, franfernandez20 and hgraphql and removed request for a team May 21, 2024 20:00
@tmctl
Copy link
Contributor

tmctl commented Jul 1, 2024

hey @zanctor just checking in on this PR. Should we revisit this? I know we've had some updates since this PR was added. Thanks!

@itsbrandondev itsbrandondev added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. labels Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants