Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TokenCancelAirdrop should fail fast with invalid parameters #17168

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Dec 23, 2024

Description:
TokenCancelAirdrop transactions should handle empty parameters appropriately.

Related issue(s):
Fixes #17167

Notes for reviewer:
This PR is in DRAFT mode for now. I have an open requirements question about whether TokenCancelAirdrop txs with empty senderId or receiverId values should return error code INVALID_PENDING_AIRDROP_ID or INVALID_ACCOUNT_ID

@kimbor kimbor changed the title TokenCancelAirdrop should fail fast with invalid parameters fix: TokenCancelAirdrop should fail fast with invalid parameters Dec 23, 2024
@kimbor kimbor added this to the v0.59 milestone Dec 23, 2024
@kimbor kimbor self-assigned this Dec 23, 2024
@kimbor kimbor changed the title fix: TokenCancelAirdrop should fail fast with invalid parameters feat: TokenCancelAirdrop should fail fast with invalid parameters Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (fe64ed3) to head (0b7bf52).

Files with missing lines Patch % Lines
...token/impl/handlers/TokenCancelAirdropHandler.java 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17168      +/-   ##
============================================
- Coverage     64.29%   64.28%   -0.01%     
+ Complexity    20905    20904       -1     
============================================
  Files          2552     2552              
  Lines         96035    96035              
  Branches      10047    10047              
============================================
- Hits          61741    61738       -3     
- Misses        30664    30665       +1     
- Partials       3630     3632       +2     
Files with missing lines Coverage Δ
...token/impl/handlers/TokenCancelAirdropHandler.java 67.92% <66.66%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fe64ed3) 95798 65180 68.04%
Head commit (0b7bf52) 95798 (+0) 65179 (-1) 68.04% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17168) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up TokenCancelAirdrop null param failure
1 participant