Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consolidate hbar transfer list when decoding cryptoTransfer function #17165

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lukelee-sl
Copy link
Member

Description:
As described in the below issue, consolidate the hbar transfer list when decoding verses after dispatch to token service.

Related issue(s):

Fixes #17163

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@lukelee-sl lukelee-sl added this to the v0.59 milestone Dec 23, 2024
@lukelee-sl lukelee-sl self-assigned this Dec 23, 2024
@lukelee-sl lukelee-sl requested review from tinker-michaelj and a team as code owners December 23, 2024 20:21
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.34%. Comparing base (7d83ba2) to head (935d655).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17165      +/-   ##
============================================
+ Coverage     64.29%   64.34%   +0.05%     
- Complexity    20906    20927      +21     
============================================
  Files          2552     2552              
  Lines         96035    96041       +6     
  Branches      10047    10048       +1     
============================================
+ Hits          61741    61799      +58     
+ Misses        30664    30609      -55     
- Partials       3630     3633       +3     
Files with missing lines Coverage Δ
...ontracts/hts/transfer/ClassicTransfersDecoder.java 47.08% <100.00%> (+27.08%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Dec 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7d83ba2) 95798 65180 68.04%
Head commit (935d655) 95804 (+6) 65240 (+60) 68.10% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17165) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @lukelee-sl ! One comment re: unnecessary exception translation, but not important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate hbar transfer list when processing cryptoTransfer HTS function
2 participants