-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consolidate hbar transfer list when decoding cryptoTransfer function #17165
base: main
Are you sure you want to change the base?
Conversation
…ction Signed-off-by: Luke Lee <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17165 +/- ##
============================================
+ Coverage 64.29% 64.34% +0.05%
- Complexity 20906 20927 +21
============================================
Files 2552 2552
Lines 96035 96041 +6
Branches 10047 10048 +1
============================================
+ Hits 61741 61799 +58
+ Misses 30664 30609 -55
- Partials 3630 3633 +3
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
...ode/app/service/contract/impl/exec/systemcontracts/hts/transfer/ClassicTransfersDecoder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @lukelee-sl ! One comment re: unnecessary exception translation, but not important.
Signed-off-by: Luke Lee <[email protected]>
Description:
As described in the below issue, consolidate the hbar transfer list when decoding verses after dispatch to token service.
Related issue(s):
Fixes #17163
Notes for reviewer:
Checklist