Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase control over how consensus service is started from deterministic image #17155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matteriben
Copy link
Contributor

@matteriben matteriben commented Dec 20, 2024

Description:

This adds an environment variable AUTO_START_CONSENSUS_SERVICE to the deterministic container image which default to "true". If set to "false" the consensus service will need to be started "manually". The consensus service may be started and stopped using the commands shown below.

Start: /package/admin/s6/command/s6-svc -o /run/service/consensus
Stop: /package/admin/s6/command/s6-svc -d /run/service/consensus

Related issue(s):

Fixes #17154

Notes for reviewer:

This change also includes some replacement of "hedera" with "consensus" in strings and filenames.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.29%. Comparing base (d3dcd58) to head (4590940).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17155      +/-   ##
============================================
+ Coverage     64.27%   64.29%   +0.01%     
- Complexity    20883    20906      +23     
============================================
  Files          2549     2552       +3     
  Lines         95976    96035      +59     
  Branches      10043    10047       +4     
============================================
+ Hits          61690    61741      +51     
- Misses        30654    30664      +10     
+ Partials       3632     3630       -2     

see 21 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Dec 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d3dcd58) 95739 65131 68.03%
Head commit (4590940) 95775 (+36) 65163 (+32) 68.04% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17155) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@matteriben matteriben self-assigned this Dec 20, 2024
@matteriben matteriben added this to the v0.58 milestone Dec 20, 2024
@matteriben matteriben force-pushed the 17154-add-ability-to-start-deterministic-consensus-container-image-without-automatically-starting-consensus-service branch from 275c49a to 16ac0d6 Compare December 20, 2024 23:43
@matteriben matteriben marked this pull request as draft December 23, 2024 16:15
@matteriben matteriben force-pushed the 17154-add-ability-to-start-deterministic-consensus-container-image-without-automatically-starting-consensus-service branch from 16ac0d6 to d062df4 Compare December 23, 2024 16:55
@matteriben matteriben force-pushed the 17154-add-ability-to-start-deterministic-consensus-container-image-without-automatically-starting-consensus-service branch from d062df4 to 4590940 Compare December 23, 2024 18:37
@matteriben matteriben marked this pull request as ready for review December 23, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ability to start deterministic consensus container image without automatically starting consensus service
1 participant