refactor: adapt StatsSigningTestingTool to work with Bytes wrapper for transactions #17144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Uzun <[email protected]>
…r transactions Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…igningTestingTool-to-work-with-Bytes
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ransactions' into 16871-adapt-StatsSigningTestingTool-to-work-with-Bytes # Conflicts: # platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ransactions' into 16871-adapt-StatsSigningTestingTool-to-work-with-Bytes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17144 +/- ##
=============================================
+ Coverage 64.28% 64.40% +0.11%
- Complexity 20886 20921 +35
=============================================
Files 2549 2549
Lines 95969 95983 +14
Branches 10041 10045 +4
=============================================
+ Hits 61690 61814 +124
+ Misses 30653 30532 -121
- Partials 3626 3637 +11
... and 16 files with indirect coverage changes |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Base automatically changed from
16703-refactor-consumer-system-transactions
to
develop
December 20, 2024 12:58
poulok
reviewed
Dec 20, 2024
| @@ -313,4 +315,9 @@ public PlatformMerkleStateRoot newMerkleStateRoot() { | |||
| public BasicSoftwareVersion getSoftwareVersion() { | |||
| return softwareVersion; | |||
| } | |||
|
|
|||
| @Override | |||
| public Bytes encodeSystemTransaction(@NonNull StateSignatureTransaction transaction) { | |||
poulok
reviewed
Dec 20, 2024
|
|
||
| if (areTransactionBytesSystemOnes((ConsensusTransaction) transaction)) { | ||
| stateSignatureTransactions.accept( | ||
| new ScopedSystemTransaction(event.getCreatorId(), event.getSoftwareVersion(), transaction)); |
There was a problem hiding this comment.
You can return after this, since the application should not do anything with the system transactions other than invoke the callback.
There was a problem hiding this comment.
Good idea. Fixed
poulok
reviewed
Dec 20, 2024
| round.forEachTransaction(this::handleTransaction); | ||
|
|
||
| round.forEachEventTransaction((event, transaction) -> { | ||
| final var transactionWithSystemBytes = handleTransaction(transaction); |
There was a problem hiding this comment.
Why not check if it is a system transaction here in the lambda before invoking handleTransaction?
…igningTestingTool-to-work-with-Bytes # Conflicts: # platform-sdk/platform-apps/demos/CryptocurrencyDemo/src/main/java/com/swirlds/demo/crypto/CryptocurrencyDemoState.java # platform-sdk/platform-apps/demos/HelloSwirldDemo/src/main/java/com/swirlds/demo/hello/HelloSwirldDemoState.java # platform-sdk/platform-apps/demos/StatsDemo/src/main/java/com/swirlds/demo/stats/StatsDemoState.java # platform-sdk/platform-apps/tests/AddressBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java # platform-sdk/platform-apps/tests/ConsistencyTestingTool/src/main/java/com/swirlds/demo/consistency/ConsistencyTestingToolState.java # platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java # platform-sdk/platform-apps/tests/MigrationTestingTool/src/main/java/com/swirlds/demo/migration/MigrationTestingToolState.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolState.java # platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java # platform-sdk/platform-apps/tests/StressTestingTool/src/main/java/com/swirlds/demo/stress/StressTestingToolState.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/PlatformMerkleStateRoot.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldState.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleTestingToolState.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/state/BlockingSwirldState.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
lpetrovic05
reviewed
Dec 23, 2024
Comment on lines
+200
to
+208
| private boolean areTransactionBytesSystemOnes(final ConsensusTransaction transaction) { | ||
| // We have maximum allocation of 100 bytes for the transaction + 10 bytes for the preamble size in | ||
| // TransactionCodec | ||
| // + 64 bytes for the maximum public key size + 64 bytes for the maximum signature size + 12 bytes for 3 | ||
| // integers | ||
| final var maximumSignedEncodedTransactionSize = 100 + 10 + 64 + 64 + 12; | ||
| return transaction.getApplicationTransaction().length() > maximumSignedEncodedTransactionSize; | ||
| } | ||
|
|
There was a problem hiding this comment.
this app has a configurable transaction size, so size cannot be used to differentiate between system and app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates StatsSigningTestingTool to work with the new Bytes format of system transactions.
Related issue(s):
Fixes #16871
Notes for reviewer:
Checklist