Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump com.google.protobuf:protoc from 3.25.4 to 4.29.2 in /hiero-dependency-versions #17127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2024

Bumps com.google.protobuf:protoc from 3.25.4 to 4.29.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner December 18, 2024 19:21
@dependabot dependabot bot added dependencies Pull requests that update a dependency file Java Pull requests that update Java code labels Dec 18, 2024
@dependabot dependabot bot requested a review from a team as a code owner December 18, 2024 19:21
@dependabot dependabot bot requested a review from dalvizu December 18, 2024 19:21
@dependabot dependabot bot requested a review from andrewb1269hg December 18, 2024 19:22
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (959c06f) 95472 64912 67.99%
Head commit (0a34d94) 95472 (+0) 64912 (+0) 67.99% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17127) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.25%. Comparing base (959c06f) to head (0a34d94).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #17127   +/-   ##
==========================================
  Coverage      64.25%   64.25%           
  Complexity     20820    20820           
==========================================
  Files           2547     2547           
  Lines          95709    95709           
  Branches       10014    10014           
==========================================
  Hits           61494    61494           
  Misses         30606    30606           
  Partials        3609     3609           

Impacted file tree graph

@dependabot dependabot bot force-pushed the dependabot/gradle/hiero-dependency-versions/com.google.protobuf-protoc-4.29.2 branch from 0a34d94 to ec3c5f1 Compare December 20, 2024 02:55
@andrewb1269hg andrewb1269hg added this to the v0.58 milestone Dec 20, 2024
@andrewb1269hg andrewb1269hg self-assigned this Dec 20, 2024
@andrewb1269hg
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 20, 2024

Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@andrewb1269hg
Copy link
Contributor

@dependabot recreate

Bumps [com.google.protobuf:protoc](https://github.com/protocolbuffers/protobuf) from 3.25.4 to 4.29.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protoc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/hiero-dependency-versions/com.google.protobuf-protoc-4.29.2 branch from ec3c5f1 to f75e590 Compare December 20, 2024 03:38
@andrewb1269hg
Copy link
Contributor

@Nana-EC @poulok @netopyr will you please look at this PR? It's a major version roll and would like additional verification and sign off from you. Thanks

andrewb1269hg
andrewb1269hg previously approved these changes Dec 20, 2024
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version roll looks good, but would like additional reviews since this is a major version roll.

@dependabot dependabot bot changed the base branch from develop to main December 21, 2024 04:17
@dependabot dependabot bot dismissed andrewb1269hg’s stale review December 21, 2024 04:17

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant