Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run swirlds-platform-tests as part of CI builds #17121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jjohannes
Copy link
Collaborator

Description:

This was missed at some point when we introduced the "aggregation" project for aggregated code coverage/test running.

@jjohannes jjohannes added this to the v0.58 milestone Dec 18, 2024
@jjohannes jjohannes self-assigned this Dec 18, 2024
@jjohannes jjohannes requested review from a team as code owners December 18, 2024 18:41
@jjohannes jjohannes requested a review from dalvizu December 18, 2024 18:41
rbarkerSL
rbarkerSL previously approved these changes Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (757afd9) to head (c27cb5b).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #17121      +/-   ##
=============================================
+ Coverage      64.30%   67.45%   +3.15%     
- Complexity     20851    22132    +1281     
=============================================
  Files           2547     2592      +45     
  Lines          95806    96969    +1163     
  Branches       10022    10106      +84     
=============================================
+ Hits           61607    65412    +3805     
+ Misses         30589    27855    -2734     
- Partials        3610     3702      +92     

see 207 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Dec 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+3.24% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (757afd9) 95569 65026 68.04%
Head commit (c27cb5b) 96732 (+1163) 68950 (+3924) 71.28% (+3.24%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17121) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jjohannes
Copy link
Collaborator Author

Requires #17123 to be integrated first for tests to pass.

@anthony-swirldslabs
Copy link
Contributor

Alternatively, requires #17128 that attempts to fix the failing test.

@jjohannes jjohannes force-pushed the run-swirlds-platform-tests-on-ci branch from 704778c to 5e4e3f1 Compare December 19, 2024 09:21
@jjohannes jjohannes force-pushed the run-swirlds-platform-tests-on-ci branch from 5e4e3f1 to f580771 Compare December 19, 2024 09:31
@jjohannes jjohannes force-pushed the run-swirlds-platform-tests-on-ci branch from f580771 to c27cb5b Compare December 19, 2024 19:16
@jjohannes jjohannes requested a review from rbarkerSL December 19, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants