Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Hip 991 submit message additional tests #17085

Open
wants to merge 8 commits into
base: hip-991-submit-message
Choose a base branch
from

Conversation

JivkoKelchev
Copy link
Contributor

@JivkoKelchev JivkoKelchev commented Dec 17, 2024

Description:

  • Adds "Negative scenarios for public topics" and "Positive scenarios for private topics" sections of the HIP-991 test plan.
    (TOPIC_FEE_158 : TOPIC_FEE_167)
  • Adds negative and positive tests from the plan (TOPIC_FEE_150 : TOPIC_FEE_153)

Related issue(s):

Fixes #16867

Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
@JivkoKelchev JivkoKelchev self-assigned this Dec 17, 2024
@JivkoKelchev JivkoKelchev added this to the v0.58 milestone Dec 17, 2024
…message-additional-tests

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip991/TopicCustomFeeSubmitMessageTest.java
Signed-off-by: Zhivko Kelchev <[email protected]>
…message-additional-tests

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip991/TopicCustomFeeSubmitMessageTest.java
@JivkoKelchev JivkoKelchev marked this pull request as ready for review December 17, 2024 12:51
@JivkoKelchev JivkoKelchev requested review from a team as code owners December 17, 2024 12:51
@JivkoKelchev JivkoKelchev requested a review from kimbor December 17, 2024 12:51
@JivkoKelchev JivkoKelchev added the Topic Fees HIP-991 implementation label Dec 17, 2024
Copy link

codacy-production bot commented Dec 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c2c4f48) 98229 64424 65.59%
Head commit (c5cfd6b) 98229 (+0) 64426 (+2) 65.59% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17085) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (c2c4f48) to head (c5cfd6b).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##             hip-991-submit-message   #17085   +/-   ##
=========================================================
  Coverage                     63.88%   63.88%           
- Complexity                    20637    20639    +2     
=========================================================
  Files                          2543     2543           
  Lines                         95464    95464           
  Branches                      10000    10000           
=========================================================
+ Hits                          60985    60988    +3     
+ Misses                        30849    30847    -2     
+ Partials                       3630     3629    -1     

see 1 file with indirect coverage changes

Impacted file tree graph

JivkoKelchev and others added 3 commits December 17, 2024 15:22
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic Fees HIP-991 implementation
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

2 participants