Only three approvals should be required to merge TCK work #235
Labels
documentation
Improvements or additions to documentation
Good First Issue
Issues which are ideal for a first time or new project contributor.
hacktoberfest
Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.
help wanted
Extra attention is needed
Milestone
🆕🐥 First Timers Only
This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.
👾 Description of the issue
Currently, the
DevelopmentProcess.md
describes that all SDK servers must be complete and tested against the TCK for a particular request type before it can be merged. It has been determined that waiting for all SDKs can result in PRs remaining open for a long time even if they are fully approved. To simplify this and allow PRs to be merged in a more timely manner, only three approvals from SDK leads should be required. This new requirement should be documented.Proposed Solution:
The requirement of only three approvals should be stated in
DevelopmentProcess.md
.📋 Step by step guide to do a contribution
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.
sign-off
information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽
🤔 Additional Information
If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.
The text was updated successfully, but these errors were encountered: