Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve donation button accessibility #952

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: improve donation button accessibility #952

wants to merge 6 commits into from

Conversation

chaniBenziman
Copy link
Collaborator

Description

Resolving #949

screenshots

Now the button looks like this:
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/12164457621/open-bus/198/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/12164457621/open-bus/198/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/12164457621/open-bus/445e030187c7e89daad1a38b21baa1d35c72740b/test-results/index.html'

NoamGaash
NoamGaash approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/pages/DonateModal/DonateModal.tsx Outdated
rel="noreferrer"
className="donate-button"
>
לתרום לסדנא →
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.
Idea for further improvement - i18n can be incorporated here, but it's not mandatory

@NoamGaash NoamGaash changed the title improve_accessibility refactor: improve donation button accessibility Nov 27, 2024
NoamGaash
NoamGaash requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I do have two concerns -

  1. I believe that the arrow has the wrong direction
  2. the lint should be fixed (npm run lint:fix - tell me if you need help with it)

have you tested it on dark mode and english mode?
image

@chaniBenziman
Copy link
Collaborator Author

how can i fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaniBenziman @NoamGaash