Fix Default Route check when not using DHCP

[tayterz2]

Problem:
#725 introduces a bug wherein if an automated deployment using userdata.yaml is initiated and does not use DHCP, the installation fails with the error "No default route found. Please check the router setting on the DHCP server" regardless of the "Gateway" settings. This is because the check is performed before a static network is set up.

Solution:
Add a couple of "if" checks to determine if this is a DHCP installation. If not, skip the default route check.

Related Issue:
#725 #734

Test plan:
Using this userdata.yaml file on a second ISO or PXE, successfully perform an automated install:

#cloud-config
token: token
os:
  ssh_authorized_keys:
    - ssh-rsa ...        # replace with your public key
  password: p@ssword   # replace with a your password
  ntp_servers:
    - 0.suse.pool.ntp.org
    - 1.suse.pool.ntp.org
install:
  mode: create
  automatic: true
  networks:
  management_interface:
    interfaces:
      - name: ens0
      - name: ens3
    method: static
    ip: 1.2.3.4
    gateway: 1.2.3.1
    subnet_mask: 255.255.255.0
  vipMode: static
  vip: 2.3.4.5

[mingshuoqiu]

The code looks good to me. Can give different commit title for 2 commits or simply squash 2 commits into a single one? Thanks

[starbops]

Thanks for sending us the patch. However, I wonder if this will fix the problem. Please describe the steps to reproduce the case. A new GH issue for it would be nice (it helps us better understand the scope of the issue regarding the context and additional details provided). I want to reproduce the problem and validate if the fix suggested by this PR works.

Many thanks.

[tayterz2]

@starbops - GH issue GH-7280 created.

[mergify]

This pull request is now in conflict. Could you fix it @tayterz2? 🙏

[tayterz2]

The code looks good to me. Can give different commit title for 2 commits or simply squash 2 commits into a single one? Thanks

Done - merged into a single commit. Temporarily broke everything, but fixed now!

Thanks!
Taylor

[tayterz2]

Resolves harvester/harvester#7280