Change LH default settings to fix maintenance mode issues (backport #788) #812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The Harvester maintenance mode is blocked by manually attached volumes and single-replica volumes.
Solution:
Change LH default setting to allow node drain on such scenarios.
Refer:
https://github.com/longhorn/charts/blob/v1.6.x/charts/longhorn/values.yaml#L248
https://github.com/longhorn/charts/blob/ad73dc01239b7eeb25ff510ce8358578433d85a5/charts/longhorn/values.yaml#L250
Related Issue:
harvester/harvester#6264
harvester/harvester#6266
Test plan:
Per issue steps.
After a new installation, get such LH default settings:
Following PRs:
This is an automatic backport of pull request #788 done by [Mergify](https://mergify.com).