Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LH default settings to fix maintenance mode issues (backport #788) #812

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 14, 2024

Problem:

The Harvester maintenance mode is blocked by manually attached volumes and single-replica volumes.

Solution:

Change LH default setting to allow node drain on such scenarios.

Refer:

https://github.com/longhorn/charts/blob/v1.6.x/charts/longhorn/values.yaml#L248

https://github.com/longhorn/charts/blob/ad73dc01239b7eeb25ff510ce8358578433d85a5/charts/longhorn/values.yaml#L250

Related Issue:
harvester/harvester#6264
harvester/harvester#6266

Test plan:

Per issue steps.

After a new installation, get such LH default settings:

default-data-path                                                 /var/lib/harvester/defaultdisk                    true      7m19s
...
detach-manually-attached-volumes-when-cordoned                    true                                              true      7m19s
...
node-drain-policy                                                 allow-if-replica-is-stopped                       true      7m19s

Following PRs:


This is an automatic backport of pull request #788 done by [Mergify](https://mergify.com).

Signed-off-by: Jian Wang <[email protected]>
(cherry picked from commit 54caa47)
@brandboat brandboat merged commit cdb43b4 into v1.4 Aug 14, 2024
7 checks passed
@brandboat brandboat deleted the mergify/bp/v1.4/pr-788 branch August 14, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants