Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support network interface boot orders in VM forms #941

Closed

Conversation

torchiaf
Copy link
Collaborator

@torchiaf torchiaf commented Jan 21, 2024

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Fixes harvester/harvester#3325

Occurred changes and/or fixed issues

TODO

  • check errors in case of removing tabs -> possible infinite lopp

Technical notes summary

Areas or cases that should be tested

  • VM Network tab -> bootOrder field

Areas which could experience regressions

  • VM Volumes tab -> bootOrder field

Screenshot/Video

Edit VM, Networks

image

VM tooltip

image

YAML

image

@torchiaf torchiaf requested a review from bk201 January 21, 2024 14:52
@torchiaf torchiaf self-assigned this Jan 21, 2024
@torchiaf torchiaf marked this pull request as draft January 22, 2024 08:12
@torchiaf torchiaf marked this pull request as ready for review January 22, 2024 23:04
Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf marked this pull request as draft January 23, 2024 08:57
@torchiaf
Copy link
Collaborator Author

Superseded by #945

@torchiaf torchiaf closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Harvester to support network booting vm's via pxe
1 participant