Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isEncrypted breaks all volume page (under testing) #1256

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Jan 3, 2025

Summary

fix: isEncrypted() breaks the volume page.

Note. I don't have Kasten env to reproduce this bug..

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#7150

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@a110605 a110605 requested review from torchiaf and houhoucoop January 3, 2025 05:45
@a110605 a110605 self-assigned this Jan 3, 2025
@torchiaf
Copy link
Collaborator

torchiaf commented Jan 3, 2025

Did you check if there are places where missing this.relatedPV breaks the UI ? Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants