Add Labels tab to Virtual Machines resource page
#1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
force-pushed
the
issue_5974_display_labels_on_vm
branch
from
abecb3b to
041123c
Compare
votdev
changed the title
Labels tab to Virtual Machines resource pageLabels tab to VirtualMachines resource page
votdev
changed the title
Labels tab to VirtualMachines resource pageLabels tab to Virtual Machines resource page
votdev
force-pushed
the
issue_5974_display_labels_on_vm
branch
2 times, most recently
from
6458103 to
b809e94
Compare
votdev
force-pushed
the
issue_5974_display_labels_on_vm
branch
2 times, most recently
from
8284df3 to
b4a05af
Compare
torchiaf
requested changes
Sep 26, 2024
Allow the user to manage the labels of a Virtual Machine resource via UI. Right now it is only possible to manage instance labels that are synced from the VM to the VMI resource. Related to: harvester/harvester#5974 Signed-off-by: Volker Theile <[email protected]>
votdev
force-pushed
the
issue_5974_display_labels_on_vm
branch
from
b4a05af to
d499b45
Compare
Signed-off-by: Volker Theile <[email protected]>
votdev
force-pushed
the
issue_5974_display_labels_on_vm
branch
from
d499b45 to
42793a7
Compare
a110605
reviewed
Nov 15, 2024
| @@ -728,6 +728,10 @@ harvester: | |||
| inNamespaces: "Workloads in these namespaces" | |||
| namespaces: | |||
| label: Namespaces | |||
| labels: | |||
| description: "" | |||
There was a problem hiding this comment.
is this key needed? description prop in KeyValue.vue default to empty string.
harvester.virtualMachine.labels.description
|
I'm good to have But the harvester/harvester#5974 is target to We should have the same PR open for harvester-ui-extension and the shell KeyValue.vue and Labels.vue change should have PR in rancher/dashboard. Unless we want to backport this PR change to v1.4.x release, it's okay to merge in this repo master and backport to havester-release-v1.4 branch. cc @torchiaf , @bk201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow the user to manage the labels of a Virtual Machine resource via UI. Right now it is only possible to manage instance labels that are synced from the VM to the VMI resource.
Fixes #harvester/harvester#5974
Screenshot/Video