Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts: initinal commit for networkfs-manager #277

Merged

Conversation

Vicente-Cheng
Copy link
Contributor

add new chart networkfs-manager

@Vicente-Cheng Vicente-Cheng force-pushed the add-networkfs-manager branch 4 times, most recently from a6add9f to 9a5e1b9 Compare September 4, 2024 02:27
@Vicente-Cheng Vicente-Cheng changed the title chart: initinal release for networkfs-manager charts: initinal commit for networkfs-manager Sep 4, 2024
Copy link
Contributor

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question - this PR includes charts/harvester-networkfs-manager/.helmignore, but #278 doesn't include that file. Is this intentional?

@Vicente-Cheng Vicente-Cheng merged commit 4cc0524 into harvester:master Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants