-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README and add an example of chart bumping #243
base: master
Are you sure you want to change the base?
Conversation
2de6305
to
a0f4060
Compare
Signed-off-by: Jian Wang <[email protected]>
a0f4060
to
74eba4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some nits, overall LGTM.
Thanks for the detailed information on how to resolve the error.
@@ -1,5 +1,4 @@ | |||
# Harvester Charts | |||
![Release Charts](https://github.com/harvester/charts/workflows/Release%20Charts/badge.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what it was used for before, and could we fix the broken image?
|
||
e.g. https://github.com/harvester/charts/pull/229 | ||
|
||
merge to `master` branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we merged master
because the chart content changed? If so, could we provide a more specific description here?
|
||
:::note | ||
|
||
The Rancher version `103.0.0` needs to increase to a next version like `103.0.1` if `103.0.0` has been used, otherwise, the `index.yaml` will not be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we refer to their readme section (https://github.com/rancher/charts?tab=readme-ov-file#upstream-charts/) for more detailed info?
issue: harvester/harvester#5866
The document writes down all the detailed steps to release a chart and bump it to upstream.