Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and add an example of chart bumping #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

w13915984028
Copy link
Member

issue: harvester/harvester#5866

The document writes down all the detailed steps to release a chart and bump it to upstream.

Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits, overall LGTM.

Thanks for the detailed information on how to resolve the error.

@@ -1,5 +1,4 @@
# Harvester Charts
![Release Charts](https://github.com/harvester/charts/workflows/Release%20Charts/badge.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what it was used for before, and could we fix the broken image?


e.g. https://github.com/harvester/charts/pull/229

merge to `master` branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we merged master because the chart content changed? If so, could we provide a more specific description here?


:::note

The Rancher version `103.0.0` needs to increase to a next version like `103.0.1` if `103.0.0` has been used, otherwise, the `index.yaml` will not be updated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we refer to their readme section (https://github.com/rancher/charts?tab=readme-ov-file#upstream-charts/) for more detailed info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants