-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add find_index, has, and reject filters #799
base: master
Are you sure you want to change the base?
Conversation
So the first issue is an inconsistent behaviour between
Consider the ruby implementation of find From my understanding the first behaviour is roughly the (new) ruby behaviour, and the second is the jekyll behaviour. I imagine this inconsistency should be addressed, as |
Ruby liquid detects Now
|
Yes I agree we need find and where to be consistent, and returning null/undefined be consistent with liquid, at least in a way that it behaves same with one more step. Not sure if there’s any other consequences but we can have a try. |
I think we can proceed as follows for the first issue: we have all these filters implement the ruby behaviour by default, and we overload Don't have a strong opinion about the other two deviations |
18c7187
to
77dfdb4
Compare
77dfdb4
to
53e76da
Compare
Implement new collection filters
find_index
,reject
andhas
to match ruby side. Fixes #798