Skip to content

Commit

Permalink
fix: rely on equal for computing contains
Browse files Browse the repository at this point in the history
This change allows contains to be computed using the toValue of the items in the array.
Before this change if I had an array of "Drop" `contains` would not match against the value.
  • Loading branch information
santialbo authored Feb 8, 2024
1 parent 4518a19 commit f3f4de3
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/render/operator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ export const defaultOperators: Operators = {
},
'contains': (l: any, r: any) => {
l = toValue(l)
r = toValue(r)
return l && isFunction(l.indexOf) ? l.indexOf(r) > -1 : false
return l && isFunction(l.some) ? l.some(i => equal(i, r)) : false;

Check failure on line 37 in src/render/operator.ts

View workflow job for this annotation

GitHub Actions / lint / Lint

Extra semicolon
},
'not': (v: any, ctx: Context) => isFalsy(toValue(v), ctx),
'and': (l: any, r: any, ctx: Context) => isTruthy(toValue(l), ctx) && isTruthy(toValue(r), ctx),
Expand Down

0 comments on commit f3f4de3

Please sign in to comment.