-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: broadcast vote power #4683
Conversation
d58a280
to
2939bdb
Compare
eea35e8
to
e2043ae
Compare
p2p.ConstructMessage(msgToSend), | ||
); err != nil { | ||
consensus.getLogger().Err(err). | ||
Msg("[LastSignPower] could not send out the ViewChange message") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the log message here
return nil, nil, true, errors.WithStack(errWrongShardID) | ||
} | ||
senderKey = maybeSP.SenderPubkey | ||
consensus.SetLastKnownSignPower(maybeSP.Commit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to capture all 3 VP :
Prepare: getOrZero(prep),
Commit: getOrZero(comm),
Change: getOrZero(view),
during an outage, most likely we won't even hit the commit phase, and during that time only view change VP will be seen.
@Frozen were you able to test that PR in localnet and confirm the VP and api calls are working fine ? hmy_getLastSigningPower at the current state is only working when this is call on the leader, now this one should work on all nodes. |
i have hmy_getLastSigningPower and hmy_getLastSigningPower2 methods to compare results, and i'm waiting for watchdog localnet integration to confirm that everything works as expected. |
@Frozen, please confirm that you are unblocked and have watchdog locally |
Looks good to me. We need to test the LastSignPowerRequest in the localnet. Other than that, everything is good. Thanks! |
Feature: broadcast vote power