Close fd when acquire fails. #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the lockfile's fd is opened when attempting to acquire the lock, and remains open until the lock is released. This means that in cases where the lock is not successfully acquired before the objects go away, a ResourceWarning of an unclosed fd is printed. This can also cause unclosed fds to accumulate, or even cause a process to run out of fds. This came up for me when attempting to clean up an old tmp/lockdir, when attempting to acquire many locks but immediately give up when unsuccessful, and then remove them when successful. This closes the lockfile fd when acquire fails to actually acquire the lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an interesting corner case the other day: The lockfile's fd is opened when attempting to acquire the lock, and remains open until the lock is released. This means that in cases where the lock is not successfully acquired before the objects go away, a ResourceWarning of an unclosed fd is printed. This can also cause unclosed fds to accumulate, or even cause a process to run out of fds.
This came up for me when attempting to clean up an old tmp/lockdir, when attempting to acquire many locks but immediately give up when unsuccessful, and then remove them when successful.
This closes the file when acquire fails to acquire the lock for any reason.