Fix captain push -Bc when on tag #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge original repo master
When checked out on a tag and pushing all branches, captain failed to remove `(HEAD detached at v1.0)` from the `git branch` output. It then tried to tag a docker container with that text of which docker would (rightly so) error out. The changes in this commit remove this extraneous text from the docker label list when on a commit not marked by a branch. In addition, only branches whose heads point to the current HEAD are considered, as opposed to all branches that contain the HEAD commit. Tests were added to `git_test.go` on a git repository to verify it behaved properly whether the current HEAD commit is pointed at by tags or branches, just tags, or just branches.
jwliechty
force-pushed
the
fix_detached_head
branch
from
d330e8b
to
55aa184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #86
When checked out on a tag and pushing all branches, captain failed to
remove
(HEAD detached at v1.0)from thegit branchoutput. It thentried to tag a docker container with that text of which docker would
(rightly so) error out. The changes in this commit remove this
extraneous text from the docker label list when on a commit not marked by
a branch. In addition, only branches whose heads point to the current HEAD
are considered, as opposed to all branches that contain the HEAD commit.
Tests were added to
git_test.goon a git repository to verify itbehaved properly whether the current HEAD commit is pointed at by tags or
branches, just tags, or just branches.
Please accept and create a new distributable. Thanks!