Install production dependencies with engines check in CI jobs #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hoping to see this fail first, and then pass once I rebase. |
We recently updated glob to v11, which does not support Node 18, and so have to downgrade it and publish another release: #330 I want to make sure we catch this in CI next time and I think this might do the trick.
lencioni
force-pushed
the
ci-engines-check
branch
from
055e39e to
7abe354
Compare
|
This correctly failed on Node 18 when glob was at v11: https://github.com/happo/happo.io/actions/runs/13378589306/job/37362894335?pr=331#step:4:10 |
|
It seems that yarn will check engines on dev deps when the production flag is set, so I don't think we can actually do it like this. yarnpkg/yarn#6966 Closing for now, will re-open if I get another idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated glob to v11, which does not support Node 18, and so have to downgrade it and publish another release:
#330
I want to make sure we catch this in CI next time and I think this might do the trick.