Add option to disable FullText indexing even if HS is enabled #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesagnew
requested review from
michaelabuckley,
tadgh and
a team
as code owners
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6426 +/- ##
============================================
+ Coverage 83.54% 83.55% +0.01%
- Complexity 27432 27792 +360
============================================
Files 1707 1740 +33
Lines 106185 107504 +1319
Branches 13397 13491 +94
============================================
+ Hits 88710 89828 +1118
- Misses 11750 11886 +136
- Partials 5725 5790 +65 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not currently possible to enable Hibernate Search but not enable fulltext indexing of all resources. This means that you can't use HS only for terminology indexing. This PR adds a fix for that. It also disables fulltext searching on the public HAPI FHIR server in an effort to stabilize it.