Skip to content

Commit

Permalink
Clean up TODOs.
Browse files Browse the repository at this point in the history
  • Loading branch information
lukedegruchy committed Nov 13, 2024
1 parent 37a9a95 commit 763921f
Showing 1 changed file with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import org.hl7.fhir.r4.model.SearchParameter;
import org.opencds.cqf.fhir.cr.measure.r4.utils.R4MeasureServiceUtils;

// LUKETODO: should we simply just NOT load this from unit tests at all?
// LUKETODO: find a better package for this
// LUKETODO: javadoc
// LUKETODO: unit test
Expand All @@ -43,21 +42,20 @@ public MeasureSearchParameterSeedingService(
myDaoRegistry = theDaoRegistry;
mySearchParamRegistry = theSearchParamRegistry;

// LUKETODO: decided whether or not to do this since we get this error:
// LUKETODO: this happens if we inject this into unit tests
/*
Caused by: java.lang.IllegalArgumentException: HAPI-2063: Unknown job definition ID: REINDEX
at ca.uhn.fhir.batch2.coordinator.JobCoordinatorImpl.lambda$startInstance$1(JobCoordinatorImpl.java:141)
at java.base/java.util.Optional.orElseThrow(Optional.java:403)
at ca.uhn.fhir.batch2.coordinator.JobCoordinatorImpl.startInstance(JobCoordinatorImpl.java:140)
*/
// create();
create();
}

// LUKETODO: figure out how to get THIS @PostConstruct to get called AFTER the one for Batch2JobRegisterer
@PostConstruct
public void start() {
create();
}
// @PostConstruct
// public void start() {
// }

public void create() {
final IFhirResourceDao<SearchParameter> searchParameterDao =
Expand Down

0 comments on commit 763921f

Please sign in to comment.