UI: updated Button style #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemis-prime
requested changes
Apr 14, 2024
There was a problem hiding this comment.
THis is not the way to accomplish what you need.
to be clear, there should be ONE main in the DOM. That is a convention. https://www.w3schools.com/tags/tag_main.asp
It does not mean "div with nice margins I need".... it means " the ONE main area of document".
Please grab the styles you need some other way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new ScreenfulBlock specifier
Changed
<div>inside ScreenfulBlock to<Main>because paddings were not working correctly on slidesrequires bump of @hanzo/ui