Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmmc: Checkout improv, auth: improved LoginComponent #52

Merged
merged 3 commits into from
Mar 8, 2024
Merged

cmmc: Checkout improv, auth: improved LoginComponent #52

merged 3 commits into from
Mar 8, 2024

Conversation

erikrakuscek
Copy link
Contributor

@erikrakuscek erikrakuscek commented Mar 8, 2024 •
edited
Loading

  • Added a hideHeader prop to LoginComponent which hides the header with "Login" title
  • Added a component for checkout as Dialog

To improve:

  • add isCheckoutOpen state to commerce service?

@erikrakuscek erikrakuscek changed the title Commerce auth/feat/checkout Checkout in hanzo/commerce, new setting for LoginComponent Mar 8, 2024
@artemis-prime artemis-prime changed the title Checkout in hanzo/commerce, new setting for LoginComponent cmmc: Checkout improv, auth: improved LoginComponent Mar 8, 2024
@artemis-prime artemis-prime merged commit 5d0955c into main Mar 8, 2024
0 of 4 checks passed
@artemis-prime artemis-prime deleted the commerce-auth/feat/checkout branch March 8, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemis-prime artemis-prime artemis-prime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikrakuscek @artemis-prime