@0.3.0: Header, SiteDef, DrawerMenu, MobileNav improvements and changes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header / Main Nav / SiteDef: cleaned up handling of featured CTA (eg, "Enter App") DrawerMenu improvements: Now in common, as it is configured for our apps (supports logo, opens from the right) closeElement (icon) is passed in. primitives/Sheet (underlying DrawerMenu) now also supports a centerElement, which we now use for an optional logo MobileNav: uses better fonts and colors, reflects siteDef.currentAs, and displays CTA properly Logo: added xs size (for mobile menu impl) TShirtSize, TShirtDimensions, added xs and xl (admin: started to use semver for this module, so calling this 0.3.0)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header / Main Nav / SiteDef: cleaned up handling of featured CTA (eg, "Enter App") DrawerMenu improvements:
Now in common, as it is configured for our apps
(supports logo, opens from the right)
closeElement (icon) is passed in.
primitives/Sheet (underlying DrawerMenu) now also supports
a centerElement, which we now use for an optional logo
MobileNav: uses better fonts and colors,
reflects siteDef.currentAs, and displays CTA properly
Logo: added xs size (for mobile menu impl)
TShirtSize, TShirtDimensions, added xs and xl
(admin: started to use semver for this module, so calling this 0.3.0)