Improve ReorderableWrap for full width widgets #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the drag targets from two horizontal/vertical rectangles to two triangles covering the upper left side for the "preDragTarget" and the lower right side for the "nextDragTarget". When a reorderable widget expands to full width, it is now more intuitive to drag it to the previous/next position. For example, without this change, the user always had to drag the widget to the left to move it to the previous position when horizontal mode was enabled. Now it is possible to simply drag it upwards on the right side of the widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the drag targets from two horizontal/vertical rectangles to two triangles covering the upper left side for the "preDragTarget" and the lower right side for the "nextDragTarget". When a reorderable widget expands to full width, it is now more intuitive to drag it to the previous/next position.
For example, without this change, the user always had to drag the widget to the left to move it to the previous position when horizontal mode was enabled. Now it is possible to simply drag it upwards on the right side of the widget.
Updated:
Before (horizontal direction):
Before (vertical direction):